Fix package distribution #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejudas
suggested changes
Jul 12, 2017
setup.py
Outdated
| "requests[security] >= 2.0.0", | ||
| ], | ||
| ':python_version>="3.3"': [ | ||
| "requests >= 2.0.0", |
There was a problem hiding this comment.
isn't requests a required package for any version of python?
Also we seem to have lost the cryptography package on < 3.0, idna package on < 3.0, pyOpenSSL on < 3.0.
There was a problem hiding this comment.
Those come with requests[security]. That's why I split it up, because Python 2.7 needs the extra installation of requests, but Python >= 3.3 doesn't.
There was a problem hiding this comment.
does requests[security] also install the core requests package?
There was a problem hiding this comment.
Also can we make this python_version<3 instead of ==2.7 so that someone on a unsupported version can at least try to install it :)
There was a problem hiding this comment.
Ditto for python_version>=3.3 => 3.0
codejudas
approved these changes
Jul 12, 2017
ghost
merged commit
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes package distribution, so
twilio-pythoninstalls the correct dependencies based on the Python version it will be running on.