Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added validation of signature without stripping port number #477

Merged
merged 8 commits into from Sep 25, 2019
Merged

added validation of signature without stripping port number #477

merged 8 commits into from Sep 25, 2019

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Sep 20, 2019 •
edited

Fixes #402
PR for DI-321

childish-sambino
childish-sambino approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

twilio/request_validator.py Outdated Show resolved Hide resolved
childish-sambino
childish-sambino approved these changes Sep 24, 2019
View reviewed changes
twilio/request_validator.py Outdated Show resolved Hide resolved
twilio/request_validator.py Show resolved Hide resolved
@eshanholtz eshanholtz merged commit d881810 into master Sep 25, 2019
@eshanholtz eshanholtz deleted the improve-request-validator branch September 25, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incoming SMS webhook failing validation (non standard SSL port)
2 participants
@eshanholtz @childish-sambino