Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add details to TwilioRestException #517

Merged
merged 4 commits into from Apr 27, 2020
Merged

feat: add details to TwilioRestException #517

merged 4 commits into from Apr 27, 2020

Conversation

ashish-s
Copy link
Contributor

@ashish-s ashish-s commented Apr 21, 2020 •
edited

Feature

Add a new property named details to RestException. Details is returned by selective apis to populate extra information about errors.
The Studio V2 flow api will be returning extra details with flow validation errors.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

thinkingserious
thinkingserious reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a test.

Also, not sure if needed, but current errors print out as follows (source):
Screen Shot 2020-04-23 at 4 26 28 PM

@ashish-s
Copy link
Contributor Author

@thinkingserious added a unit test for rest exception

@childish-sambino childish-sambino merged commit 1a0d02d into twilio:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashish-s @thinkingserious @childish-sambino