Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed file exec to get version #561

Merged
merged 2 commits into from
Feb 19, 2021
Merged

chore: removed file exec to get version #561

merged 2 commits into from
Feb 19, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke commented Feb 19, 2021 •
edited
Loading

Simplifying logic to populate the version in setup.py by moving it to librarian

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Related PR

@shwetha-manvinkurke shwetha-manvinkurke merged commit e440229 into main Feb 19, 2021
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shwetha-manvinkurke @thinkingserious