Replaces libxml with Nokogiri #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri has much wider adoption with Ruby users than libxml. Some developers were having trouble with libxml installation. libxml doesn't work on JRuby, but Nokogiri will. The API doesn't change. Bonus The unused `indent` argument to `TwiML` has been removed.
Adds jruby to Travis CI config.
codejudas
approved these changes
Nov 16, 2017
This was referenced Nov 17, 2017
|
|
||
| opts = { encoding: 'UTF-8', indent: 0 } | ||
| document = Nokogiri::XML::Document.new | ||
| xml = self.xml(document).to_xml(opts).gsub(/\n/, '') |
There was a problem hiding this comment.
@philnash any reason for replacing the new-line character here?
|
I solved this by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise that I'm touching some generated code here, but I wanted to see if this could be done and potentially influence the generator. I also wanted to open a PR to see the results of the CI run.
What do you think?
Nokogiri has much wider adoption with Ruby users than libxml.
Some developers were having trouble with libxml installation.
libxml doesn't work on JRuby, but Nokogiri will.
The API doesn't change.
Bonus
The unused
indentargument toTwiMLhas been removed.