Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding http logging for ruby #538

Merged
merged 5 commits into from Nov 17, 2020
Merged

feat: adding http logging for ruby #538

merged 5 commits into from Nov 17, 2020

Conversation

shwetha-manvinkurke
Copy link
Contributor

Fixes

https://issues.corp.twilio.com/browse/DI-946

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

childish-sambino
childish-sambino reviewed Nov 13, 2020
View reviewed changes
lib/twilio-ruby/rest/client.rb Outdated Show resolved Hide resolved
lib/twilio-ruby/rest/client.rb Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke changed the title feat: adding http loggig for ruby feat: adding http logging for ruby Nov 14, 2020
childish-sambino
childish-sambino reviewed Nov 16, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
spec/rest/client_spec.rb Outdated Show resolved Hide resolved
lib/twilio-ruby/rest/client.rb Outdated Show resolved Hide resolved
childish-sambino
childish-sambino approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

@shwetha-manvinkurke shwetha-manvinkurke merged commit 33a0349 into main Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shwetha-manvinkurke @thinkingserious @childish-sambino