Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add secondary token support to Rack::TwilioWebhookAuthentication #600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsteinberg
Copy link

@jsteinberg jsteinberg commented Feb 28, 2022

Fixes

Add support for multiple auth tokens to Rack::TwilioWebhookAuthentication middleware. The goal of having multiple tokens is to support Secondary Auth Tokens

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@cristofer
Copy link

@jsteinberg are you still using a forked version of Twilio-ruby to accomplish this, just because nobody cares about giving feedback on this feature?

@jsteinberg
Copy link
Author

@jsteinberg are you still using a forked version of Twilio-ruby to accomplish this, just because nobody cares about giving feedback on this feature?

Not using a fork. We just implemented this manually in the controller instead of relying on the middleware provided by the gem.

Its not a lot of code.

VALIDATORS.any? do |validator|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants