Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: added common environment variable name for auth config #695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/twilio-ruby/base/client_base.rb
Expand Up @@ -11,8 +11,8 @@ class ClientBase
# rubocop:disable Metrics/ParameterLists
def initialize(username = nil, password = nil, account_sid = nil, region = nil, http_client = nil, logger = nil,
user_agent_extensions = nil)
@username = username || Twilio.account_sid
@password = password || Twilio.auth_token
@username = username || Twilio.account_sid || ENV['TWILIO_ACCOUNT_SID']
@password = password || Twilio.auth_token || ENV['TWILIO_AUTH_TOKEN']
@region = region || Twilio.region
@edge = Twilio.edge
@account_sid = account_sid || @username
Expand Down