Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Continuously read from buffer while no errors occur. #11

Merged
merged 4 commits into from Jan 2, 2024
Merged

fix: Continuously read from buffer while no errors occur. #11

merged 4 commits into from Jan 2, 2024

Conversation

AlejandroOrozco
Copy link
Contributor

@AlejandroOrozco AlejandroOrozco commented Dec 22, 2023 •
edited by yafuquen

Description

  • There was an issue with the buffer from CellularSession.m, Apparently, the buffer was closing itself after being put on hold, rather than waiting to read the entire package from the SSLRead.

Commit message

  • fix: Continuously read from buffer while no errors occur.

Screenshot

Testing

  • Added unit tests
  • Ran unit tests successfully
  • Added documentation for public APIs and/or Wiki

@AlejandroOrozco AlejandroOrozco added the enhancement New feature or request label Dec 22, 2023
@AlejandroOrozco AlejandroOrozco self-assigned this Dec 22, 2023
@yafuquen yafuquen changed the title update: Continuously read from buffer while no errors occur. fix: Continuously read from buffer while no errors occur. Dec 24, 2023
SergioFierro
SergioFierro reviewed Dec 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@SergioFierro SergioFierro self-requested a review December 28, 2023 14:39
@yafuquen yafuquen merged commit 876798c into main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioFierro SergioFierro SergioFierro approved these changes

@yafuquen yafuquen yafuquen approved these changes

Assignees

@AlejandroOrozco AlejandroOrozco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlejandroOrozco @SergioFierro @yafuquen