Ahoyapps 495 switch camera #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 13, 2020 16:39
charliesantos
requested changes
Apr 15, 2020
| @@ -35,7 +35,8 @@ export default function VideoTrack({ track, isLocal, priority }: VideoTrackProps | |||
| }, [track, priority]); | |||
|
|
|||
| // The local video track is mirrored. | |||
| const style = isLocal ? { transform: 'rotateY(180deg)' } : {}; | |||
| const isFrontFacing = track.mediaStreamTrack.getSettings().facingMode !== 'environment'; | |||
There was a problem hiding this comment.
How about track.mediaStreamTrack.getSettings().facingMode === 'user';? Because if facingMode is left or right, this evaluates to true.
There was a problem hiding this comment.
facingMode is a property that seems to exist only on mobile devices. So isFrontFacing would be false when using the app on my laptop, and the video would not be mirrored when it should be.
Also, according to MDN, facingMode of left and right represents cameras that are front facing, just pointed over the user's left or right shoulder. I can't think of any devices with these cameras, but we would want isFrontFacing to be true in those cases.
added 2 commits
April 15, 2020 15:14
…-video-app-react into AHOYAPPS-495-switch-camera
charliesantos
approved these changes
Apr 15, 2020
jasonpennington5308
added a commit
to jasonpennington5308/twilio-video-app-react
that referenced
this pull request
Apr 16, 2020
Ahoyapps 495 switch camera (twilio#152)
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* create FlipCameraButton component and add to menubar * Pass facingMode to GetLocalVideoTracks * Only mirror video when front-facing * Add low priority to video publish * Add comment * Fix tests * Add tests for FlipCameraButton * Rename variable * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds an icon that allows mobile users to toggle between their front and rear facing cameras. Users can do this before or after they join a room.
Burndown
Before review
npm testBefore merge