Grid mode pagination #654
Merged
Grid mode pagination #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
February 7, 2022 22:18
olipyskoty
suggested changes
Mar 11, 2022
| @@ -63,7 +63,7 @@ export default function useLocalTracks() { | |||
| if (isAcquiringLocalTracks || audioTrack || videoTrack) return Promise.resolve(); | |||
|
|
|||
| setIsAcquiringLocalTracks(true); | |||
|
|
|||
| console.log(3); | |||
There was a problem hiding this comment.
I think I removed this just before you submitted the review 🙂. I'm not sure why it reappeared though!
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('should not render the previous page button when the user is viewing the last page', () => { |
There was a problem hiding this comment.
should this be should not render the next page button ...
olipyskoty
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds a pagination feature to the video app. The user can move to the previous or next page of participants (where applicable), or they can click on a specific page to see. The user can also choose the maximum number of participants to see in the grid in the Settings. The grid should correctly handle the adding and removing of participants while on any page, including the last page. It should also handle changing the max grid participants setting while on any page.
Burndown
Before review
npm testBefore merge