-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize grid mode #699
Merged
Merged
Finalize grid mode #699
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1442950
change name from grid mode to grid view
olipyskoty 35ccd13
update pagination participants to be consistent with iOS
olipyskoty a1d4c6e
update max grid participants options
olipyskoty 920ff1e
fix failing GridView test
olipyskoty 4c5490e
fix failing usePagination tests
olipyskoty ab05ffb
update screensharing behavior
olipyskoty fe2738d
fix failing room tests
olipyskoty 2690dc8
have cypress tests use collab view
olipyskoty 0d40256
add gridview background to theme and move usePagination to /GridView
olipyskoty c29ad7d
add padding to participant tiles
olipyskoty 0b36cbc
change "Collaboration" to "Presentation"
olipyskoty 10dcd10
deactivate grid view for cypress tests
olipyskoty b1a0e71
update room tests
olipyskoty a365f34
remove unneeded beforeEach hooks in cypress tests
olipyskoty e5f8b1f
fix eslint error
olipyskoty 55f7c9f
change participant border color to match grid background
olipyskoty 4e3fbaa
add comments to cypress tests for clarity
olipyskoty File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,14 @@ module.exports = (on, config) => { | |
args, | ||
}); | ||
const page = (participants[name] = await browser.newPage()); // keep track of this participant for future use | ||
|
||
// These tests were written before Grid View was implemented. This app now activates | ||
// Grid View by default, so here we activate Presentation View before visiting the app so | ||
// that the tests can pass. | ||
await page.evaluateOnNewDocument(() => { | ||
localStorage.clear(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, comment would be good. |
||
localStorage.setItem('grid-view-active-key', false); | ||
}); | ||
await page.goto(config.baseUrl); | ||
await page.type('#input-user-name', name); | ||
await page.type('#input-room-name', roomName); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a quick comment here about what this does would be good.