Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename environment variables for API_SID and API_SECRET #75

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Feb 11, 2020

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This PR renames the API_KEY and API_SECRET environment variables to TWILIO_API_KEY_SID and TWILIO_API_KEY_SECRET. The readme has also been updated.

This is to bring things in line with the Twilio console. A user reported some confusion about this in the JS pilot.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit d1ccceb into development Feb 11, 2020
@timmydoza timmydoza deleted the update-api-variable-name branch February 11, 2020 18:46
@ijt ijt mentioned this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants