-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using 1.0.0 beta14 #109
Using 1.0.0 beta14 #109
Conversation
@@ -16,7 +16,7 @@ class ViewController: UIViewController { | |||
|
|||
// Configure access token manually for testing, if desired! Create one manually in the console | |||
// at https://www.twilio.com/user/account/video/dev-tools/testing-tools | |||
var accessToken = "TWILIO_ACCESS_TOKEN" | |||
var accessToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiIsImN0eSI6InR3aWxpby1mcGE7dj0xIn0.eyJqdGkiOiJTS2U0NGRiMjRhZmE5MTg1YjQ2YWZjMDE1NTg2OTQxZDlhLTE0OTIwMjY1MjAiLCJncmFudHMiOnsiaWRlbnRpdHkiOiJwdGFuayIsInJ0YyI6eyJjb25maWd1cmF0aW9uX3Byb2ZpbGVfc2lkIjoiVlMzZjc1ZTBmMTRlN2M4YjIwOTM4ZmM1MDkyZTgyZjIzYSJ9fSwiaWF0IjoxNDkyMDI2NTIwLCJleHAiOjE0OTIwMzM3MjAsImlzcyI6IlNLZTQ0ZGIyNGFmYTkxODViNDZhZmMwMTU1ODY5NDFkOWEiLCJzdWIiOiJBQzk2Y2NjOTA0NzUzYjMzNjRmMjQyMTFlOGQ5NzQ2YTkzIn0.FkJNaMvX5peAwBE9ghTGjL67dkGsNtHdbcT3aVUfOC0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove access token.
@@ -86,6 +86,49 @@ class ViewController: UIViewController { | |||
let tap = UITapGestureRecognizer(target: self, action: #selector(ViewController.dismissKeyboard)) | |||
self.view.addGestureRecognizer(tap) | |||
} | |||
|
|||
func setupRemoteVideoView() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a comment mentioning that this is an example of programmatically creating a TVIVideoView
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
// MARK: TVIVideoViewDelegate | ||
extension ViewController : TVIVideoViewDelegate { | ||
func videoViewDidReceiveData(_ view: TVIVideoView) { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't implement this method if its not needed.
VideoQuickStart/ViewController.swift
Outdated
// MARK: TVIVideoViewDelegate | ||
extension ViewController : TVIVideoViewDelegate { | ||
func videoViewDidReceiveData(_ view: TVIVideoView) { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't implement if not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptankTwilio left review feedback.
In 1.0.0-beta We have replaced TVIVideoViewRenderer by TVIVideoView. This PR addresses changes in swift quickstart apps to use the new TVIVideoView APIs