Using 1.0.0 beta14 #109
Merged
Using 1.0.0 beta14 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceaglest
reviewed
Apr 12, 2017
| @@ -16,7 +16,7 @@ class ViewController: UIViewController { | |||
|
|
|||
| // Configure access token manually for testing, if desired! Create one manually in the console | |||
| // at https://www.twilio.com/user/account/video/dev-tools/testing-tools | |||
| var accessToken = "TWILIO_ACCESS_TOKEN" | |||
| var accessToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiIsImN0eSI6InR3aWxpby1mcGE7dj0xIn0.eyJqdGkiOiJTS2U0NGRiMjRhZmE5MTg1YjQ2YWZjMDE1NTg2OTQxZDlhLTE0OTIwMjY1MjAiLCJncmFudHMiOnsiaWRlbnRpdHkiOiJwdGFuayIsInJ0YyI6eyJjb25maWd1cmF0aW9uX3Byb2ZpbGVfc2lkIjoiVlMzZjc1ZTBmMTRlN2M4YjIwOTM4ZmM1MDkyZTgyZjIzYSJ9fSwiaWF0IjoxNDkyMDI2NTIwLCJleHAiOjE0OTIwMzM3MjAsImlzcyI6IlNLZTQ0ZGIyNGFmYTkxODViNDZhZmMwMTU1ODY5NDFkOWEiLCJzdWIiOiJBQzk2Y2NjOTA0NzUzYjMzNjRmMjQyMTFlOGQ5NzQ2YTkzIn0.FkJNaMvX5peAwBE9ghTGjL67dkGsNtHdbcT3aVUfOC0" | |||
ceaglest
reviewed
Apr 12, 2017
| @@ -86,6 +86,49 @@ class ViewController: UIViewController { | |||
| let tap = UITapGestureRecognizer(target: self, action: #selector(ViewController.dismissKeyboard)) | |||
| self.view.addGestureRecognizer(tap) | |||
| } | |||
|
|
|||
| func setupRemoteVideoView() { | |||
There was a problem hiding this comment.
I would add a comment mentioning that this is an example of programmatically creating a TVIVideoView.
ceaglest
reviewed
Apr 12, 2017
| // MARK: TVIVideoViewDelegate | ||
| extension ViewController : TVIVideoViewDelegate { | ||
| func videoViewDidReceiveData(_ view: TVIVideoView) { | ||
| } |
There was a problem hiding this comment.
Don't implement this method if its not needed.
ceaglest
reviewed
Apr 12, 2017
VideoQuickStart/ViewController.swift
Outdated
| // MARK: TVIVideoViewDelegate | ||
| extension ViewController : TVIVideoViewDelegate { | ||
| func videoViewDidReceiveData(_ view: TVIVideoView) { | ||
| } |
There was a problem hiding this comment.
Don't implement if not needed.
ceaglest
suggested changes
Apr 12, 2017
ceaglest
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.0.0-beta We have replaced TVIVideoViewRenderer by TVIVideoView. This PR addresses changes in swift quickstart apps to use the new TVIVideoView APIs