Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter Bower support #24

Closed
Siyfion opened this issue Apr 8, 2013 · 13 comments
Closed

Add Twitter Bower support #24

Siyfion opened this issue Apr 8, 2013 · 13 comments

Comments

@Siyfion
Copy link
Contributor

Siyfion commented Apr 8, 2013

See: http://twitter.github.io/bower/ for details.

@Dayde
Copy link

Dayde commented Apr 23, 2013

Hi,
It would be really nice to have this library available on bower. It does not seem too difficult as you already have the JSON manifest and are using semver:
bower register ng-upload git://github.com/twilson63/ngUpload.git

Should I register it, or do you prefer to do it yourself?
If for some reason you're not ok with this maybe you should close the issue.

Anyway thanks for this very useful lib :)

@twilson63
Copy link
Owner

Hey Dayde,

I plan on registering this week, just reading through Brian Fords Blog a
couple of days ago, I think their api is changing to bower.json or
something. Anyway, I should have it implemented by the weekend. :-)

Thanks for suggesting it.

Tom

On Tue, Apr 23, 2013 at 7:47 AM, Dayde notifications@github.com wrote:

Hi,
It would be really nice to have this library available on bower. It does
not seem too difficult as you already have the JSON manifest and are using
semver:
bower register ng-upload git://github.com/twilson63/ngUpload.git

Should I register it, or do you prefer to do it yourself?
If for some reason you're not ok with this maybe you should close the
issue.

Anyway thanks for this very useful lib :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-16853374
.

Tom Wilson
Jack Russell Software Company Division of CareKinesis
494 Wando Park Blvd
Mount Pleasant, SC 29464
Phone: 843-881-2171
Email: tom@jackhq.com
Web: http://www.jackhq.com
Calendar:
http://www.google.com/calendar/embed?src=tom%40jackrussellsoftware.com&ctz=America/New_Yorkhttp://www.jackhq.com/calendar

This e-mail may contain information that is confidential, privileged or
otherwise protected from disclosure by the Health Insurance Portability and
Accountability Act (HIPAA) and other state and federal laws. This
information is intended only for the individual names above. Any review,
use disclosure or dissemination of this material is strictly prohibited.
If you receive this information in error, please notify CareKinesis
immediately at 888-974-2763 and delete the original at once.

@Dayde
Copy link

Dayde commented Apr 23, 2013

Ok great :)

Looking forward to bower install it ^^

@twilson63
Copy link
Owner

@Dayde

I just registered to bower, if you get a chance please confirm that its registered correctly.

Thx

Tom

@Dayde
Copy link

Dayde commented Apr 28, 2013

Everything's working.

Thanks again for you work on that lib :)

Dayde

@twilson63
Copy link
Owner

Cool Beans, thanks for the nudge to get it up on bower!

Cheers!

Tom

On Sun, Apr 28, 2013 at 7:01 PM, Dayde notifications@github.com wrote:

Everything's working.

Thanks again for you work on that lib :)

Dayde


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-17144639
.

Tom Wilson
Jack Russell Software Company Division of CareKinesis
494 Wando Park Blvd
Mount Pleasant, SC 29464
Phone: 843-881-2171
Email: tom@jackhq.com
Web: http://www.jackhq.com
Calendar:
http://www.google.com/calendar/embed?src=tom%40jackrussellsoftware.com&ctz=America/New_Yorkhttp://www.jackhq.com/calendar

This e-mail may contain information that is confidential, privileged or
otherwise protected from disclosure by the Health Insurance Portability and
Accountability Act (HIPAA) and other state and federal laws. This
information is intended only for the individual names above. Any review,
use disclosure or dissemination of this material is strictly prohibited.
If you receive this information in error, please notify CareKinesis
immediately at 888-974-2763 and delete the original at once.

@Siyfion
Copy link
Contributor Author

Siyfion commented Apr 29, 2013

@Dayde @twilson63 Are you guys sure it's working okay? If I use the registered version as opposed to the GitHub repo, it won't install as there's no corresponding tag. @twilson63 you need to tag the code for each version you release on bower, ie. at the moment you need to create a v0.3.4 tag.

@Dayde
Copy link

Dayde commented Apr 29, 2013

Still working for me I got the commit 48744ac which is the latest if I'm not wrong.

@Siyfion
Copy link
Contributor Author

Siyfion commented Apr 29, 2013

@Dayde How are you getting it though? You can't be using a component.json file with a version specified..? Which most people will want, you don't always want the latest version, you want the version your program is designed to run with! 😟

@Dayde
Copy link

Dayde commented Apr 29, 2013

hmm I see what you mean, I only used bower install ngUpload so it gets me the latest version which is associated to the latest commit. I'm not familiar enough with bower to tell how to configure the versionning :/
I'll try to figure that out.

@twilson63
Copy link
Owner

Got it.

I just pushed a tag v0.3.4 to the repo. @Siyfion does this work for you? Or do I need to do something else?

Thanks

Tom

@Siyfion
Copy link
Contributor Author

Siyfion commented Apr 30, 2013

Yup, works fine now. Just try to make sure that the github tags and the component.json file are kept in-sync 😄

@twilson63
Copy link
Owner

Thanks, totally missed it in the bower documentation.

Thx

Tom

Sent from my iPhone

On Apr 30, 2013, at 4:27 AM, Simon Mansfield notifications@github.com
wrote:

Yup, works fine now. Just try to make sure that the github tags and the
component.json file are kept in-sync [image: 😄]


Reply to this email directly or view it on
GitHubhttps://github.com//issues/24#issuecomment-17215074
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants