API 呼び出しの try の範囲を狭める
#609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HosokawaR
force-pushed
the
fix/api-callback-error-handling
branch
from
ee0c3b1
to
e907ae7
Compare
HosokawaR
force-pushed
the
fix/api-callback-error-handling
branch
from
e907ae7
to
f54c3d2
Compare
HikaruEgashira
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
以下のコメントの通りです。
Resolves #585
補足
他にも
tryが大きすぎるところはありますが、特にここは大きかったので修正しました。これを修正しないと、API 呼び出しの部分のコードで発生したなんらかのエラーはすべて
NetworkErrorになってしまいます。その場合 #593 で Sentry を導入しても、プロダクトの改善が難しくなってしまうので、取り急ぎここの部分だけ修正しました。
変更
tryの範囲を狭めました。