Skip to content

Commit

Permalink
Remove requires from individual components
Browse files Browse the repository at this point in the history
Solves the warning below that appears in projects that only require individual components of twingly-amqp.

> warning: loading in progress, circular require considered harmful

To avoid the warning this feature is removed and users will have to require the complete twingly-amqp.
  • Loading branch information
Pontus4 committed Nov 3, 2020
1 parent 1c584d3 commit 483293b
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 23 deletions.
3 changes: 3 additions & 0 deletions lib/twingly/amqp.rb
Expand Up @@ -8,8 +8,11 @@
require "twingly/amqp/default_exchange_publisher"
require "twingly/amqp/topic_exchange_publisher"
require "twingly/amqp/null_logger"
require "twingly/amqp/message"

require "bunny"
require "ostruct"
require "json"

module Twingly
module AMQP
Expand Down
2 changes: 0 additions & 2 deletions lib/twingly/amqp/connection.rb
@@ -1,5 +1,3 @@
require "twingly/amqp"

module Twingly
module AMQP
class Connection
Expand Down
3 changes: 0 additions & 3 deletions lib/twingly/amqp/default_exchange_publisher.rb
@@ -1,6 +1,3 @@
require "twingly/amqp/publisher"
require "twingly/amqp/connection"

module Twingly
module AMQP
class DefaultExchangePublisher
Expand Down
2 changes: 0 additions & 2 deletions lib/twingly/amqp/message.rb
@@ -1,5 +1,3 @@
require "json"

module Twingly
module AMQP
class Message
Expand Down
5 changes: 0 additions & 5 deletions lib/twingly/amqp/pinger.rb
@@ -1,8 +1,3 @@
require "twingly/amqp/connection"
require "twingly/amqp/ping_options"
require "twingly/amqp/default_exchange_publisher"
require "json"

module Twingly
module AMQP
class Pinger
Expand Down
3 changes: 0 additions & 3 deletions lib/twingly/amqp/publisher.rb
@@ -1,6 +1,3 @@
require "json"
require "ostruct"

module Twingly
module AMQP
module Publisher
Expand Down
2 changes: 0 additions & 2 deletions lib/twingly/amqp/session.rb
@@ -1,5 +1,3 @@
require "bunny"

module Twingly
module AMQP
class Session
Expand Down
3 changes: 0 additions & 3 deletions lib/twingly/amqp/subscription.rb
@@ -1,6 +1,3 @@
require "twingly/amqp/connection"
require "twingly/amqp/message"

module Twingly
module AMQP
class Subscription
Expand Down
3 changes: 0 additions & 3 deletions lib/twingly/amqp/topic_exchange_publisher.rb
@@ -1,6 +1,3 @@
require "twingly/amqp/publisher"
require "twingly/amqp/connection"

module Twingly
module AMQP
class TopicExchangePublisher
Expand Down

0 comments on commit 483293b

Please sign in to comment.