-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Node v10 #24
Comments
I'm not sure this works or if you have to specify an exact version for "allow_failures". Anyway, this is just a temporary fix until #24 has been solved. Also cleaned up the version we test against: * 5.x and 7.x removed as their EOL was at 2016-06-30 * 8.x is the current active LTS release (see https://github.com/nodejs/Release)
We could do #17 and see if this is still an issue :) |
Running the tests with Node v8.9.4 records fixtures correctly, but running with v9.5.0 does not record anything.
Fixture after running with Node v8.9.4// File: test/cassettes/search_without_valid_api_key.js
module.exports = exports = function(nock) {
var refs = [];
refs[0] = nock('http://api.twingly.com:443')
.get('/blog/search/api/v3/search?apikey=wrong&q=something')
.reply(401, "<?xml version=\"1.0\" encoding=\"utf-8\"?><error code=\"40101\"><message>Unauthorized</message></error>", { server: 'nginx',
date: 'Thu, 15 Feb 2018 15:23:25 GMT',
'content-type': 'application/xml; charset=utf-8',
'content-length': '97',
connection: 'close',
'cache-control': 'no-cache',
pragma: 'no-cache',
expires: '-1' });
return refs;
}; Fixture after running with Node v9.5.0// File: test/cassettes/search_without_valid_api_key.js
module.exports = exports = function(nock) {
var refs = [];
return refs;
}; It looks like there's some changes in the new node version that's not compatible with |
I also discovered that you can make the tests pass on 9.5.0 by manually editing |
Updated the title since Node v9 is EOL since 2018-06-30. The current release is v10. |
Also removed v4 from the build matrix since it's EOL was at 2018-04-30. (https://github.com/nodejs/Release#end-of-life-releases) close #24
The following specs fails for unknown reasons when running them with Node
v9.5.0
. I'm not sure whether this just has to do with the tests or if it is something else in the API client that doesn't work in the new Node version.(This was discovered in #23)
The text was updated successfully, but these errors were encountered: