Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release a new version (without idn-ruby) #110

Closed
jage opened this issue Feb 24, 2017 · 4 comments
Closed

Release a new version (without idn-ruby) #110

jage opened this issue Feb 24, 2017 · 4 comments
Labels
enhancement

Comments

@jage
Copy link
Contributor

jage commented Feb 24, 2017

Lots of good work that's not released: v5.0.1...master
@roback
Copy link
Member

roback commented Mar 3, 2017

Im unsure on which version to bump. I think the fact that we now support JRuby should count as a minor release at least.

@jage
Copy link
Contributor Author

jage commented Mar 3, 2017

Im unsure on which version to bump. I think the fact that we now support JRuby should count as a minor release at least.

I'm thinking minor as well.

The only spec changes are regarding an bug (patch) v5.0.1...master#diff-9cc625410830734f3ecfe98392f89acd so I nothing should "break".

@dentarg
Copy link
Collaborator

dentarg commented Mar 3, 2017

Sure, 5.1.0 sounds good to me too.

@roback
Copy link
Member

roback commented Mar 3, 2017

5.1.0 it is then :)

@roback roback closed this as completed in a686ac6 Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jage @dentarg @roback