New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `Twingly::URL::Hasher.blogstream_hash` #152

Closed

roback opened this issue Dec 21, 2021 · 0 comments · Fixed by #153

Labels

enhancement small

Member

roback commented Dec 21, 2021

We don't have any use for this method anymore.

twingly-url/lib/twingly/url/hasher.rb

Lines 22 to 24 in 32c5c2d

    
           def blogstream_hash(url) 
        
             MD5_DIGEST.hexdigest(url)[0..29].upcase 
        
           end

roback added enhancement small labels

Chrizpy added a commit that referenced this issue


          Remove Twingly::URL::Hasher.blogstream_hash

d4619d6

Since blogbox have been decomissioned and blogstream is on its way out,
the code removed in this commit would have been dead code if left behind.

See issue: #152
See Trello: https://trello.com/c/x2KWY2Mo/3686-sprint108-avveckla-blog-box

close #152

Chrizpy mentioned this issue

Remove Twingly::URL::Hasher.blogstream_hash #153

Merged

Chrizpy closed this as completed in #153

Chrizpy added a commit that referenced this issue


          Merge pull request #153 from twingly/issue/152/remove-blogstream-hash

d9eb885

Since blogbox have been decomissioned and blogstream is on its way out,
the code removed in this commit would have been dead code if left behind.

See issue: #152
See Trello: https://trello.com/c/x2KWY2Mo/3686-sprint108-avveckla-blog-box

close #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment