Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to extract URLs from text without normalizing #34

Closed
jage opened this issue Jun 29, 2015 · 3 comments
Closed

Method to extract URLs from text without normalizing #34

jage opened this issue Jun 29, 2015 · 3 comments

Comments

@jage
Copy link
Contributor

jage commented Jun 29, 2015

Currently we have Twingly::URL::Normalizer.normalize() which can extract URLs, but it will normalize the URLs at the same time. We need a method that can just extract URLs from text with no normalization.

@dentarg
Copy link
Collaborator

dentarg commented Jul 3, 2015

Me and @jage talked some about this issue, from another issue:

Uhm, to just add it, not hard. To not create a mess, pretty hard. We already have an extract_url method in the normalizer. So this should be in the url class, which now returns an object with a .url accessor ... it should probably just delegate everything except .domain etc ...

@jage suggested we could try some mob programming refactoring twingly-url, WDYT @walro @roback?

@roback
Copy link
Member

roback commented Jul 3, 2015

👍 That would be a good idea.

@walro
Copy link
Contributor

walro commented Jul 3, 2015

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants