Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return nil #35

Closed
dentarg opened this issue Jul 13, 2015 · 1 comment
Closed

Do not return nil #35

dentarg opened this issue Jul 13, 2015 · 1 comment
Labels
enhancement

Comments

@dentarg
Copy link
Collaborator

dentarg commented Jul 13, 2015

url and domain can be nil:

twingly-url/lib/twingly/url.rb

Line 29 in 7ea8c42

[]

That makes it harder to use this library, because you always need to check for nil... (example: https://github.com/twingly/norrstrom/issues/56)
@dentarg
Copy link
Collaborator Author

dentarg commented Jul 13, 2015

We will probably cover this in the refactoring we talked about in #34.

twingly-mob added a commit that referenced this issue Oct 13, 2015
@twingly-mob
Work with Twingly::URL objects instead of strings
3c6986b 
...and maybe more.

Related to #11, #31, #35.
@twingly-mob twingly-mob mentioned this issue Oct 13, 2015
Merged
4 tasks
@walro walro closed this as completed in #42 Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dentarg