Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to logical requires #103

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Switch to logical requires #103

merged 2 commits into from
Jan 15, 2018

Conversation

dentarg
Copy link
Collaborator

@dentarg dentarg commented Nov 4, 2016

Avdi in Ruby Tapas 242:

Setting up a gem to use logical require paths internally is even
easier. Since RubyGems automatically adds the gem’s lib directories to
the load path, in that case we don’t need to mess around with the load
path at all.

@dentarg
Switch to logical requires
560b64b 
Avdi in Ruby Tapas 242:

> Setting up a gem to use logical require paths internally is even
> easier. Since RubyGems automatically adds the gem’s lib directories to
> the load path, in that case we don’t need to mess around with the load
> path at all.
@dentarg dentarg changed the title Switch to logical requires [WIP] Switch to logical requires Nov 5, 2016
@dentarg
Copy link
Collaborator Author

dentarg commented Nov 5, 2016

WIP because I didn't look at the specs

@walro
Copy link
Contributor

walro commented Jan 3, 2018

Are we gonna finish this one up?

@dentarg
Copy link
Collaborator Author

dentarg commented Jan 3, 2018

I hope so :)

@dentarg
Copy link
Collaborator Author

dentarg commented Jan 8, 2018

WIP because I didn't look at the specs

Do we need specs?

@dentarg dentarg changed the title [WIP] Switch to logical requires Switch to logical requires Jan 8, 2018
@walro
Copy link
Contributor

walro commented Jan 8, 2018

Do we need specs?

Not sure what the original comment was referring to, but I don't think we need specs to ensure we use require properly. I thought it meant remove require_relative from specs.

@walro
Copy link
Contributor

walro commented Jan 8, 2018

I thought it meant remove require_relative from specs.

We don't seem to have any left.

@dentarg
Copy link
Collaborator Author

dentarg commented Jan 8, 2018

Yeah, the tests we have should be sufficient for this change

@dentarg
Copy link
Collaborator Author

dentarg commented Jan 8, 2018

Build failed due to network problems in the Travis CI container (time out when fetching gems), restarted

@dentarg dentarg merged commit c5fb131 into master Jan 15, 2018
@dentarg dentarg deleted the logical-requires branch January 15, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walro walro walro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dentarg @walro