Load the pure-Ruby IDNA implementation from Addressable #120
Conversation
|
Hm, how does https://github.com/sporkmonger/addressable/blob/addressable-2.5.2/lib/addressable/uri.rb#L20 come into play? |
|
We require pure before uri in url.rb
Not sure it matters tho?
… On 28 Feb 2018, at 12:01, Robin Wallin ***@***.***> wrote:
Hm, how does https://github.com/sporkmonger/addressable/blob/addressable-2.5.2/lib/addressable/uri.rb#L20 come into play?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Wouldn't it "monkey patch" itself and fallback to the idn-ruby implementation again? Guess it's fairly easy to try out if we modifiy a local copy of addressable. |
|
The require itself will solve the problem in #119, but we will still expect the pure implementation to run, not the native one. Not sure how to solve. We probably want |
Or explicitly prohibit the use of |
|
... or we're fine as-is. I think we need to start run tests with the gem ( I'll approve this :) |
There was a problem hiding this comment.
This fixes the issue, but it's a symptom of something else, see: #120 (comment)
|
Ah, I think I understand what you are getting at. That Addressable (when used by twingly-url) will behave differently if
Yeah, that entered my mind too. |
Exactly, sorry for the long route to get to that. |
Since #113, twingly-url can only be used with the pure-Ruby implementation in Addressable.
If idn-ruby (libidn wrapper gem) is installed, Addressable will not load the pure-Ruby implementation, which breaks twingly-url.
Close #119