Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip URLs of leading and trailing non-breaking space (and space, but we already did) #126

Merged
merged 10 commits into from
Feb 5, 2019
Merged

Strip URLs of leading and trailing non-breaking space (and space, but we already did) #126

merged 10 commits into from
Feb 5, 2019

Commits on Nov 21, 2018

  1. Handle URLs with non-breaking space 

    https://en.wikipedia.org/wiki/Non-breaking_space
    @dentarg
    dentarg committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    7ebf239 View commit details
    Browse the repository at this point in the history

  2. Be consistent, use uppercase for Unicode codepoint

    @dentarg
    dentarg committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    e62d427 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Merge branch 'master' into handle-non-breaking-space

    @jage
    jage committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    991dbaa View commit details
    Browse the repository at this point in the history

  2. Strip input from both space and non-breaking space 

    Related to #126, making the whitespace removal more general.
    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    759028a View commit details
    Browse the repository at this point in the history

  3. Terminology: starting -> leading 

    Seems more common to use "leading" than "starting" when talking about
whitespace.
    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    1bdb310 View commit details
    Browse the repository at this point in the history

  4. Only string literals get automatic freeze

    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    31a56d3 View commit details
    Browse the repository at this point in the history

  5. Improve naming, use constant for whitespace regex

    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    77d54ad View commit details
    Browse the repository at this point in the history

  6. Improve naming

    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    ae9e161 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #131 from twingly/strip-whitespace 

    Strip input from both space and non-breaking space
    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    e9f58da View commit details
    Browse the repository at this point in the history

  8. Remove dead code 

    Because we want to clean the input (#126), we are always working with a
string. #126 (comment)
    @dentarg
    dentarg committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    e43ac10 View commit details
    Browse the repository at this point in the history