Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Ruby >= 2.6 #157

Merged
merged 3 commits into from Oct 14, 2022
Merged

Require Ruby >= 2.6 #157

merged 3 commits into from Oct 14, 2022

Conversation

Pontus4
Copy link
Contributor

@Pontus4 Pontus4 commented Aug 23, 2022 •
edited

Both Ruby 2.5 and 2.6 have reached EOL, but JRuby 9.3 still requires Ruby 2.6, which is why we have to allow it.

@Pontus4
Require Ruby >= 2.7
1d987cf 
Both Ruby 2.5 and 2.6 have reached EOL.
Chrizpy
Chrizpy approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@Chrizpy Chrizpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pontus4
Copy link
Contributor Author

Pontus4 commented Oct 10, 2022

JRuby 9.3.x is compatible with Ruby 2.6.x, which is why the check fails. I guess we have to lock the Ruby version to >= 2.6 instead then...

@Chrizpy
Copy link
Contributor

Chrizpy commented Oct 10, 2022 •
edited

JRuby 9.3.x is compatible with Ruby 2.6.x, which is why the check fails. I guess we have to lock the Ruby version to >= 2.6 instead then...

Yeah, looking more closely now it seems to me that the latest JRuby version only supports Ruby compatibility up to 2.6.x.

They have a meta issue issue since 2020 that collects the efforts for an upcoming 2.7 (maybe also beyond) support. Looks like these changes are coming in into JRuby-9.4.x.x That is also why the jruby-head in the CI passes, since it uses jruby 9.4.0.0-SNAPSHOT (3.1.0) (from CI log).

EDIT: Looks like 2.7 will be skipped :D jruby/jruby#6691

@Pontus4
Copy link
Contributor Author

Pontus4 commented Oct 10, 2022

The 9.4 release will for sure be out before Rubyconf this fall but we are hopeful we can deliver it months before that time frame.

jruby/jruby#6691 (comment)

Since this was written in 2021, I guess it was delayed...

@Pontus4
Require Ruby >= 2.6
4a5aba7 
Noticed that JRuby 9.3 requires Ruby 2.6, which is why it has to be allowed. I also added Ruby 2.6 to the CI tests because we still allow it, even though it has reached EOL.
@Pontus4 Pontus4 changed the title Require Ruby >= 2.7 Require Ruby >= 2.6 Oct 13, 2022
roback
roback approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@roback roback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@Pontus4 Pontus4 merged commit aeca2a9 into master Oct 14, 2022
@Pontus4 Pontus4 deleted the require-ruby-2.7 branch October 14, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roback roback roback approved these changes

@Chrizpy Chrizpy Chrizpy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pontus4 @Chrizpy @roback