Refactor requires

[dentarg]

With the refactoring of spec_helper, a bug like this can now be caught by

bundle exec rspec spec/lib/twingly/url/utilities_spec.rb

but I did not succeed in catching it in

bundle exec rake

We can continue to work on that from this.

Close #56.

[roback]

I get the same error when running just the NullURL specs. (it must have access to the URL class here: https://github.com/twingly/twingly-url/blob/master/lib/twingly/url/null_url.rb#L8)

This is not a problem in production since you never should require null_url by yourself.

$ bundle exec rspec spec/lib/twingly/url/null_url_spec.rb

Failures:

  1) Twingly::URL::NullURL#trd
     Failure/Error: subject { url.trd }
     NoMethodError:
       undefined method `trd'
     # ./lib/twingly/url/null_url.rb:8:in `method_missing'
     # ./spec/lib/twingly/url/null_url_spec.rb:24:in `block (3 levels) in <top (required)>'
     # ./spec/lib/twingly/url/null_url_spec.rb:25:in `block (3 levels) in <top (required)>'
...

[walro]

I get the same error when running just the NullURL specs. (it must have access to the URL class here: https://github.com/twingly/twingly-url/blob/master/lib/twingly/url/null_url.rb#L8)

This is not a problem in production since you never should require null_url by yourself.

I guess we should fix it anyway

[walro]

I guess we should fix it anyway

Done in 4172a38

[roback]

Done in 4172a38

👍

[walro]

I think this looks good now

[roback]

Tested locally, LGTM :)

[walro]

Will wait with new version release until we have gotten our other ongoing PRs in