Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose userinfo, user and password #84

Merged
merged 4 commits into from
May 23, 2016
Merged

Expose userinfo, user and password #84

merged 4 commits into from
May 23, 2016

Conversation

jage
Copy link
Contributor

@jage jage commented May 23, 2016

This will cause a minor version bump

Close #73

@walro
Copy link
Contributor

walro commented May 23, 2016

Maybe tests for the other two (edge) cases:

user:@twingly.com and :password@twingly.com?

@jage
Copy link
Contributor Author

jage commented May 23, 2016

Maybe tests for the other two (edge) cases:

Sure!

@walro
Copy link
Contributor

walro commented May 23, 2016

LGTM!

@jage jage merged commit 749fe48 into master May 23, 2016
@jage jage deleted the issue/73/expose-userinfo branch May 23, 2016 09:33
jage added a commit that referenced this pull request May 23, 2016
@jage
Bump to 4.1.0
535f93d 
To release #84 (issue #73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jage @walro