Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Twingly::URL#ttld, "true TLD" getter #88

Merged
merged 5 commits into from
Aug 31, 2016
Merged

Add Twingly::URL#ttld, "true TLD" getter #88

merged 5 commits into from
Aug 31, 2016

Commits on Aug 30, 2016

  1. Add Twingly::URL#ttld, "true TLD" getter 

    Many[1] ccTLDs have introduced a second level underneath their ccTLD, but
often, we don't care about the second level. We want the "true TLD".

Discussed in https://github.com/twingly/wally/issues/49.

[1]: https://en.wikipedia.org/wiki/Second-level_domain
    @dentarg
    dentarg committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    0bb2845 View commit details
    Browse the repository at this point in the history

  2. Fix example typo

    @dentarg
    dentarg committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    585fff0 View commit details
    Browse the repository at this point in the history

  3. Fix mistake in NullURL spec

    @dentarg
    dentarg committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    6f55f91 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. Add clarifying comment about Twingly::URL#ttld

    @dentarg
    dentarg committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    03d1f92 View commit details
    Browse the repository at this point in the history

  2. Add test for when the TLD is just one level

    @dentarg
    dentarg committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    910373d View commit details
    Browse the repository at this point in the history