Default Model Enforces Falsehoods about Names, here is the fix. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todays Brain Breaking (In a good way) Link:
https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
Summary of the Issue
This project is great, but its enforcement of first/last names is a legal/cultural issue depending on where you are in the world due to the above and could be called out as not culturally sensitive enough, and so in the interest of making this more open and used - and also because I think its a great start for a project - I have patched the tests and the code and the initial SQL version to only use a single full_name field.
Tests
All tests run passing green locally but if they fail, let me know as I had issues getting my test runner updated.