General questions concerning Twire and the fork

[DPTJKKVH]

This issue can be used to ask general questions on Twire and everythint related to the fork.

~~Hello,

since I wasn't able to find your contact info I ask here. I just found your porject in F-Droid and saw that it is a fork of Pocket Player. I hope this doesn't sound unfriendly but I wonder what are your motivations for forking? It would help me deciding which project to use.

Many thanks in advance!

edit: just found your email. Hope it's fine if I leave this issue open anyway.~~

[Perflyst]

I forked the project because the original work contains evil google shit and the author didnt want to maintain two version nor remove google in his project to get it on F-Droid. I wanted a Twitch Client on F-Droid.

…

On April 2, 2019 11:57:13 AM UTC, DPTJKKVH ***@***.***> wrote: Hello, since I wasn't able to find your contact info I ask here. I just found your porject in F-Droid and saw that it is a fork of Pocket Player. I hope this doesn't sound unfriendly but I wonder what are your motivations for forking? It would help me deciding which project to use. Many thanks in advance! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/Perflyst/Twire/issues/2

[Perflyst]

Please note, I have nothing against the author nor his opinions. He even helped me solving a question. It is just that I dont like google in my apps.

…

On April 2, 2019 11:57:13 AM UTC, DPTJKKVH ***@***.***> wrote: Hello, since I wasn't able to find your contact info I ask here. I just found your porject in F-Droid and saw that it is a fork of Pocket Player. I hope this doesn't sound unfriendly but I wonder what are your motivations for forking? It would help me deciding which project to use. Many thanks in advance! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/Perflyst/Twire/issues/2

[DPTJKKVH]

Thanks for the quick reply and I fully agree. I want to avoid google proprietary binary blobs as well. Cleaned up versions of google-fied apps are very common on f-droid fortunately.

May I suggest you add one or two lines to the README to make the purpose of this fork transparent for everyone who walks by? Maybe also include this in the f-droid store text?

Either way this issue can be closed. Thanks! :)

[Porkepix]

@Perflyst I'm using up this issue as well as I think something deserve to be clarified the same way the reason for forking: will you try to maintain common codebase or starting from now it's going to evolve on its own, without being concerned with Pocket Player evolution? Asked another way, contributions are going to be only on one side, both?
This also brings question for issues: I opened some here, but should it be opened on the upstream project? (Now that I ask, I guess upstream developper won't want any report from forks actually looking at its standpoint on maintaining two platforms and being on F-droid).

[Perflyst]

I don't know for sure yet. I will of course update libraries and port features from the original app to this fork. I do not know if the original developer ports stuff back to his app.
Depending on how much time I have I will start adding new features. Feel free to open also an issue in the original app.

[DPTJKKVH]

Personally I would prefer that you just keep up with upstream while removing the proprietary Google stuff.

But I don't want to sound demanding. It's just a suggestion.

[Perflyst]

There are a lot of feature requests in the issue section. I am not sure yet, we will see.
What I am for sure do, is porting all features from the upstream to this version.

[DPTJKKVH]

Do what is fun for you and what you feel is right.

My concerns simply stem from multiple experiences that deviating away from upstream too much can introduce incompatibilities and other issues. I simply wanted to voice this once.

Either way I am enjoying your fork very much and want to thank you for creating an f-droid compatible version.

[alexzorin]

I'm of the suspicion that upstream is never going to get attention again, so there's no meaningful consequence to diverging from it. I have had a chat badge PR sitting there for a long time without attention.

Anyway, I'm happy somebody bothered to publish a de-Googled fork, I felt bad maintaining my own one. I'd be happy to bring open some PRs for some of the changes I've made, if you want.

[Perflyst]

Of course, feel free to open PR's. I have seen your repo, if you want you can get write access to the repo. Do you have some kind of instant chat (matrix/xmpp/irc/) so I can contact you?

[alexzorin]

Yeah! I use IRC mostly, but nowhere public these days. Where can I find you?

I'll have to think about how best to go about this - my commits are not very clean and I've ripped out or replaced big chunks of functionality. Not particularly motivated to 'go back in time' and re-implement them today, but there's definitely some stuff (like silencing ads) that would be worthwhile.

[Perflyst]

I am "perflyst" on freenode. Just msg me

[saasasasasa]

Hello. Can you update the app on f-droid please? Because I don't know anything about bulding the app from code. Last version there is 1.92

[Perflyst]

Yes, but #42 needs to be fixed. I did not had time too look at it.

[saasasasasa]

Ok, thank you for the answer and for making this awesome app.

[Perflyst]

New version should be on F-Droid soon, INFO: Successfully built version 1.9.6 of com.perflyst.twire

[saasasasasa]

Hey. I don't know if it's a bug, an infinished feature or maybe I'm missing something. I have a phone with 18:9 display aspect ratio and when I play a 16:9 stream it's filling out my screen so the pixels at the top and bottom are cut out. I can't find any option about it in the settings and the screen gesture doesn't work. This happens in the new 1.9.6 version, I went back to 1.9.2 and it's good there, it shows the original aspect ratio stream.

[Perflyst]

Looks like a bug, can you please open a new issue?