New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Ubuntu 20.04 and make sure braid code works for a migration. #279
Conversation
def cb_got_client(client): | ||
issuingService = AcmeIssuingService( | ||
cert_store=DirectoryStore(certificates), | ||
client=client, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glyph this is using txacme-v2 form my fork
this is the main change that is breaking the txacme API with v2.
I needed to initiate the client outside of the service, so that for example if the URL is not valid, the service is not started.
At the same time, having control over the client makes testing much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just drop txacme entirely and use certbot in webroot mode? That's effectively what we've been doing manually in production lately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well... txacme-v2 works and is already setup with braid.
I am not -1 on using certbot, but I don't have much time and I would spend the remaining time doing the migration, rather than refactoring braid.
but after the migration we can refactor the code to use certbot.
but the long term plan is to stop using t-web and just use GitHub Pages + GitHub Wiki + Read The Docs for our websites ... and hopefully we can also migrate to GitHub Issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, if we don't need to mess around with the configuration, it's fine to use this as-is.
This is a common error that I have fixed it by removing lines 719 ...
|
Also, authbind is not working... I am not sure why... I went with We can look at authbind later. |
Hi @adiroiban, sorry I missed this the first time around. I wish I'd seen this when working up #280; it would have helped. I think that we should merge this for the same reasons as that PR: it's best if master reflects the actual state of dornkirk. |
well… not Dornkirk, any more. That machine is gone :) |
I am going to merge this. Note that I am considering the Azure VM migration - Plan B. For the long term, I hope we can get rid of that VM and move all Twisted infra to SaaS services ... There is this PR to update the presentation website twisted/twisted.github.io#6 |
I have migrated base , t--web and trac to https://twisted-vm.centralus.cloudapp.azure.com/trac/
These are the changes I made
it's an upgrade from ubuntu 16.04 to 20.04
it contains various fixes.
TODO
config/trac-env/files/attachments/
you and up withconfig/trac-env/files/attachments/attachments