Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py imports ampoule (breaks if Twisted is missing at setup time) #5

Closed
moshez opened this issue Dec 14, 2017 · 2 comments
Closed

setup.py imports ampoule (breaks if Twisted is missing at setup time) #5

moshez opened this issue Dec 14, 2017 · 2 comments

Comments

@moshez
Copy link
Contributor

moshez commented Dec 14, 2017

In the setup.py file for Ampoule, line 19 imports ampoule. The only place it is used is for version information. This import breaks the install if Twisted is not available on the system path at the time. Would it be possible to explicitly enter the version in setup.py or read it from a file instead of importing the module?
@moshez moshez changed the title setup.py install broken setup.py imports ampoule (breaks if Twisted is missing at setup time) Dec 18, 2017
@moshez
Copy link
Contributor Author

moshez commented Dec 18, 2017

This should probably be fixed by moving to calver and incremental

@moshez moshez mentioned this issue Dec 25, 2017
Merged
@moshez
Copy link
Contributor Author

moshez commented Dec 25, 2017

Fixed in #21

@moshez moshez closed this as completed Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moshez