move 'wear' action to 'garments' module #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| player.thing, | ||
| u" wrestles with basic personal problems."]))) | ||
|
|
||
| evt = events.Success( |
There was a problem hiding this comment.
I understand that this is "just" moving the action to a different module, but while you are at it - Is there a specific reason why the name evt is used instead of something slightly more descriptive?
There was a problem hiding this comment.
woohoo a code review!
I could avoid naming the variable entirely; after all, it's just created, then broadcast. No name is better than a bad name :). What do you think?
There was a problem hiding this comment.
👍 to "no name is better than a bad name" in this case, since events.Success(...) makes sense to me.
|
LGTM. |
|
Thanks for re-reviewing … near instantaneously :). Will merge when CI is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #55 and #54, start to split out an action from the too-long
actionmodule.