re-wrap some docstrings that are mis-formatted or too long #83
Conversation
| @@ -35,7 +35,7 @@ | |||
| "Topic :: Terminals"], | |||
| packages=find_packages() + ['axiom.plugins', 'xmantissa.plugins'], | |||
| install_requires=[ | |||
| "twisted>=14.0.0", | |||
| "twisted>=14.0.0,<16.4.0", | |||
There was a problem hiding this comment.
oh? Out of curiosity, what did 16.4 break?
There was a problem hiding this comment.
It might be http://twistedmatrix.com/trac/ticket/8843? In any case, there should be a comment explaining the issue as best it is understood (ideally linking to a ticket, but even just the comment from the commit would be sufficient).
There was a problem hiding this comment.
Yep. I put a comment on there. Instead of adding a version constraint, I'm just adding a workaround and linking to the issue.
|
|
||
| @ivar action: The action which was being processed when an ambiguity was | ||
| found. | ||
| found. |
There was a problem hiding this comment.
Looks like this is missing a @type.
There was a problem hiding this comment.
While it should perhaps have a @type, I don't think that this should block this PR.
|
Please merge after adding some reasoning behind the twisted version cap. |
add a workaround instead
|
Thanks @tomprince for the review! |
eimaginaryandobjectsincluded.