Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle Closed in Go #95

Merged
merged 2 commits into from
Nov 15, 2020
Merged

handle Closed in Go #95

merged 2 commits into from
Nov 15, 2020

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Nov 7, 2020

Fixes #94

I'm somewhat confident is is a good idea. There might be a larger issue to deal with but this small change at least gets rid of the really egregiously wrong behavior.

@coveralls
Copy link

coveralls commented Nov 7, 2020 •
edited

Coverage Status

Coverage increased (+0.01%) to 92.656% when pulling e8ebf04 on 94.go-closed into 8720b02 on master.

mithrandi
mithrandi approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@mithrandi mithrandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like open/closed should be a property of exits, not containers, and I guess that is the purpose of IObstruction? That's out of the scope of this PR though, so approving.

@mithrandi mithrandi merged commit e47ed95 into master Nov 15, 2020
@mithrandi mithrandi deleted the 94.go-closed branch November 15, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithrandi mithrandi mithrandi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An attempt to move to a "closed" container results in an unhandled exception
3 participants
@exarkun @coveralls @mithrandi