Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an extension for dataclass based classes #596

Open
tristanlatr opened this issue Jun 2, 2022 · 2 comments · Fixed by #577
Open

Create an extension for dataclass based classes #596

tristanlatr opened this issue Jun 2, 2022 · 2 comments · Fixed by #577
Labels
enhancement extensions good first issue

Comments

@tristanlatr
Copy link
Contributor

@dataclasses.dataclass can be used from python3.7, it acts a bit like @attr.s, so adding support for it shouldn't be too complicated.

Also I realize that there are many modules that converts class variables into instance variables (pydantic, dataclasses, attrs, django models, and others), so there is probably something to do to avoid to much code duplications.
@tristanlatr tristanlatr linked a pull request Jul 13, 2022 that will close this issue
Refactor to create attrs extension instead of having the code inside our astbuilder #577
Merged
@tristanlatr tristanlatr reopened this Jul 20, 2022
@tristanlatr
Copy link
Contributor Author

Same goes for namedtuples.

@tristanlatr
Copy link
Contributor Author

And eventually the datatclass decorator?

@tristanlatr tristanlatr mentioned this issue Jun 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement extensions good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to create attrs extension instead of having the code inside our astbuilder twisted/pydoctor
1 participant
@tristanlatr