Allow to choose members order of classes and modules #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 92.68% 92.70% +0.02%
==========================================
Files 47 47
Lines 8279 8304 +25
Branches 1828 1833 +5
==========================================
+ Hits 7673 7698 +25
Misses 347 347
Partials 259 259 ☔ View full report in Codecov by Sentry. |
…sentation order of members. Add some tests.
tristanlatr
commented
Sep 17, 2022
tristanlatr
commented
Sep 22, 2022
tristanlatr
commented
Oct 17, 2022
|
This looks good, I’m just unsure we absolutely need to introduce two new arguments… this sounds like a lot. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…es from docstring fields. Should we store the linenumber as the docstring_lineno as well ?
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Mar 26, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…d warnings at the correct location.
…or into 485-and-580-members-order
|
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options --cls-member-order and --mod-member-order, fixes #580 and fixes #485.