New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency cleanup #155
Dependency cleanup #155
Conversation
* Remove setup.cfg [metadata] section, which didn't match setup.py and is deprecated anyway[1]. * Instead of depending on Twisted's various TLS dependencies directly, depend on Twisted[tls] which has been present since at least Twisted 16.0.0 (but retain a higher PyOpenSSL dep for Python 3, since Twisted[tls] requires a lesser version). [1]: https://wheel.readthedocs.io/en/latest/#defining-conditional-dependencies
Hopefully CI will be happy, but I'm inclined to merge. |
It looks like the virtualenv that travis defaults to has a setuptools that isn't new enough to correctly support the environment markers used. |
Wait... virtualenv is the component that reads these descriptions? |
virtualenv vendors setuptools & pip. That's where a new virtual
environment's setuptools & pip come from.
Maybe put a `pip install -U virtualenv` in the Travis config?
|
Is it not a serious problem that old setuptools can't install the package? I mean, the Python packaging morass wouldn't be such a problem if we could count on users to have the latest pip installed, would it? Could we just require pyOpenSSL >= 0.15.1 in all cases? 0.13 is from 2011. The only reason I see keep using it (based on the changelog) is that it is the last release prior to |
Current coverage is 96.31% (diff: 100%)@@ master #155 diff @@
==========================================
Files 19 19
Lines 1710 1710
Methods 0 0
Messages 0 0
Branches 152 152
==========================================
Hits 1647 1647
Misses 42 42
Partials 21 21
|
Requiring a newer version seems reasonable (twisted 16.4 is requiring pyopenssl 16.0.0 anyway). Regarding newer pip/setuptools, I know the most recent version of pip was the most common downloader on pypi a day after it was released. |
service_identity has also dropped support for pyOpenSSL < 0.14, so I think that bumping treq's dependency is definitely the right move. I'm working on shepherding Travis to success now, which is proving a little difficult with the Fastly TLS incident. |
@glyph If you still wish to merge, we're green here. |
[metadata]
section, which didn't match setup.py and is deprecated anyway.Twisted[tls]
requires a lesser version).