Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixup to recent agent changes #108

Merged
merged 1 commit into from Jul 30, 2015
Merged

Small fixup to recent agent changes #108

merged 1 commit into from Jul 30, 2015

Conversation

hynek
Copy link
Member

@hynek hynek commented Jul 29, 2015

There was a small race condition between @glyph and me. This PR should fix that. :)

  • it links the Agent docs which should be useful if someone is reading about it
  • show a more practical example instead of an opaque function
  • simplify the agent logic. kwargs isn’t used further down so no need to remove agent from it
  • add a doc string to the test
  • some whitespace fixes

@codecov-io
Copy link

Current coverage is 95.84%

Merging #108 into master will not affect coverage as of b426a85

@@            master    #108   diff @@
======================================
  Files           20      20       
  Stmts         1417    1417       
  Branches       113     113       
  Methods          0       0       
======================================
  Hit           1358    1358       
  Partial         19      19       
  Missed          40      40       

Review entire Coverage Diff

Powered by Codecov

@glyph
Copy link
Member

glyph commented Jul 30, 2015

Anything tested using mock.Mock makes me nervous and I wish we had more real testing 😞 . But that's a different PR.

glyph added a commit that referenced this pull request Jul 30, 2015
Small fixup to recent agent changes
@glyph glyph merged commit 0218252 into twisted:master Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants