Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Digest authentication support #111

Closed
wants to merge 6 commits into from
Closed

HTTP Digest authentication support #111

wants to merge 6 commits into from

Conversation

mksh
Copy link
Contributor

@mksh mksh commented Aug 27, 2015

tox tests failed for some reason in prev PR, so reopening
#84

@mksh
Copy link
Contributor Author

mksh commented Aug 27, 2015

I'm receiving those SSL support is unavailable failures again; uncertain what I've missed for proper tox running.

@mithrandi
Copy link
Contributor

My suspicion is that these errors are due to a bad cached version of cryptography (built with the wrong cffi); clearing the Travis build cache should fix this, if someone with the right permissions can try this.

@codecov-io
Copy link

Current coverage is 95.16%

Merging #111 into master will decrease coverage by -1.02% as of 595b3da

@@            master    #111   diff @@
======================================
  Files           19      19       
  Stmts         1548    1696   +148
  Branches       121     137    +16
  Methods          0       0       
======================================
+ Hit           1489    1614   +125
- Partial         19      28     +9
- Missed          40      54    +14

Review entire Coverage Diff as of 595b3da

Powered by Codecov. Updated on successful CI builds.

@jameshilliard
Copy link
Contributor

This appears to fail when used with a post request instead of a get request.

Error Message:
exceptions.AssertionError: Got invalid pre-authentication response code, probably URL does not support Digest auth

jameshilliard
jameshilliard reviewed Jul 31, 2016
View reviewed changes
treq/auth.py
if self.digest_auth_cache.get((method, uri), None) is None:
# Perform first request for getting the realm;
# the client awaits for 401 response code here
d = self._agent.request(method, uri,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting method statically to 'GET' on this line should fix digest auth for post requests

@jameshilliard jameshilliard mentioned this pull request Jul 31, 2016
Merged
@mksh mksh closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mksh @mithrandi @codecov-io @jameshilliard