Allow async responses from RequestTraversalAgent #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2015 14:37
Previously, only completely synchronous responses would pass through successfully. Now, any sync or async response will pass through without issue. This adds a `flush` method to RequestTraversalAgent and StubTreq to pass data through.
Current coverage is
|
|
The test docstrings here could really use a refresher on https://jml.io/pages/test-docstrings.html :) |
| clientProtocol, isServer=False, | ||
| hostAddress=clientAddress, peerAddress=serverAddress) | ||
|
|
||
| # Twisted 13.2 compatibility. |
There was a problem hiding this comment.
If this is only for 13.2, shouldn't we avoid overwriting that method if it's already set?
|
I think I'm pretty happy with this, and the issues I've mentioned are not actually new issues, or worth addressing in this PR. Please do some followups if you have the time. |
glyph
added a commit
that referenced
this pull request
Oct 10, 2015
Allow async responses from RequestTraversalAgent
pawelmhm
pushed a commit
to pawelmhm/treq
that referenced
this pull request
Nov 4, 2016
added example for "catch-all" routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh, and I fixed a bug in an unrelated test.