Mention, and emphasise, HTTPClient #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyph pointed out that the various treq request functions (`treq.get()`, `treq.post()`, etc.) don't need to be modified. Instead, the documentation should suggest that you use a `treq.client.HTTPClient` instance directly if you need to customize its behavior. This reverts commit 972b84f.
…client.HTTPClient` is meant to be used.
Fixes this warning:
../CHANGELOG.rst:24: WARNING: 'any' reference target not found: treq.testing
moshez
approved these changes
Mar 26, 2020
docs/api.rst
Outdated
| @@ -6,6 +6,11 @@ This page lists all of the interfaces exposed by the `treq` package. | |||
| Making Requests | |||
| --------------- | |||
|
|
|||
| The :py:mod:`treq` module provides several shortcut functions for making | |||
There was a problem hiding this comment.
Would "convenience" be a better word here (and below) than "shortcut"?
There was a problem hiding this comment.
Sure, that makes sense to me.
|
Thank you for the review, @moshez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #129 merged forward.