Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 2.7 and 3.5 support #310

Merged
merged 5 commits into from Dec 27, 2020
Merged

Deprecate Python 2.7 and 3.5 support #310

merged 5 commits into from Dec 27, 2020

Conversation

twm
Copy link
Contributor

@twm twm commented Dec 23, 2020

Changelog entries only: give notice of the pending removal.

Closes #309.

Closes #306.

@twm twm requested a review from a team December 26, 2020 23:57
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

So the next release of treq will continue to support 2.7 and 3.5 but this will be the last release with support for those python versions.

changelog.d/306.removal.rst Outdated Show resolved Hide resolved
@twm
Copy link
Contributor Author

twm commented Dec 27, 2020

Thank you for the review, @adiroiban!

I am merging despite the red status from Coveralls because this is a documentation-only PR that can't legitimately affect coverage.

@twm twm merged commit 37895b0 into twisted:master Dec 27, 2020
@twm twm deleted the deadsnakes branch December 27, 2020 07:18
@adiroiban
Copy link
Member

I am merging despite the red status from Coveralls because this is a documentation-only PR that can't legitimately affect coverage.

maybe replace with codecov ?

I had issues with both services, but lately codecov is better, especially if you merge the coverage reports yourself before submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Python 2.7 support Deprecate Python 3.5 support
2 participants