-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.4 #18
Release 1.0.4 #18
Conversation
I think this is ready for review needs-review |
@pmisik if you have time, you can try the release candidate with py3.12 I guess that once this is released, we will need to update twisted/twisted |
Thanks @glyph for the review. Note that the current release is done via the already existing fixed GitHub API token . I don't have admin permissions for PyPi for twisted-iocpsupport |
1.0.4 available at https://pypi.org/project/twisted-iocpsupport/ In twisted/twisted this will be used automatically |
I rolled out permissions a bit slowly with the org feature on PyPI, but I've started pruning non-org contributors and giving the core team "owner" status on more projects now. So you should have admin permissions now. Do you need them to address any current concerns though? My understanding was that the automated PyPI releases on this repo are pretty thorough |
Thanks.
The current API token works and the release was done. It's just that if it would have stopped working, I would have not had permission to generate a new token. |
@adiroiban thank you for incredible fast response. |
What hangs ? I think that you should be able to run buildbot on Windows without the iocp reactor. I agree that the deprecationWarning should be fixed in twisted/twisted Regards |
Scope and purpose
To get support for python 3.12
How to check
Check the README rendering on https://github.com/twisted/twisted-iocpsupport/tree/release-1.0.4
Check pypi pre-release https://pypi.org/project/twisted-iocpsupport/1.0.4rc1/