Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use harcoded digest for non-group key exchanges #10203

Closed
twisted-trac opened this issue May 24, 2021 · 3 comments
Closed

Don't use harcoded digest for non-group key exchanges #10203

twisted-trac opened this issue May 24, 2021 · 3 comments

Comments

@twisted-trac
Copy link

adiroiban's avatar @adiroiban reported
Trac ID trac#10203
Type enhancement
Created 2021-05-24 19:20:15Z

Right now conch uses SHA1 for non-group key exchanges.

It should use _kex.getHashProcessor(self.kexAlg)() to allow for SHA2 KEX.

For example to support the algorightms from #10202https://datatracker.ietf.org/doc/html/rfc8268

Searchable metadata
trac-id__10203 10203
type__enhancement enhancement
reporter__adiroiban adiroiban
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__conch conch
keywords__None None
time__1621884015663991 1621884015663991
changetime__1621897381277337 1621897381277337
version__None None
owner__adiroiban1 adiroiban1

@twisted-trac
Copy link
Author

adiroiban's avatar @adiroiban commented

pr #1603

@twisted-trac
Copy link
Author

twm's avatar @twm set owner to adiroiban1

Approved, thank you! #1603 (review)

@twisted-trac
Copy link
Author

adiroiban's avatar @adiroiban set status to closed

In changeset da61086

#!CommitTicketReference repository="" revision="da61086f167ce2096ad0652faecb6ba87f8caed8"
Merge pull request #1603 from twisted/10203-fixed-group-kex-sha

[#10203] Use KEX registry to get digest algorithm for non-group KEX algorithms.

Author: adiroiban
Reviewer:  twm
Fixes: ticket:10203

Use KEX registry to get digest algorithm for non-group KEX algorithms.

JudgeGregg pushed a commit to JudgeGregg/twisted that referenced this issue Sep 2, 2022
[twisted#10203] Use KEX registry to get digest algorithm for non-group KEX algorithms.

Author: adiroiban
Reviewer:  twm
Fixes: ticket:10203

Use KEX registry to get digest algorithm for non-group KEX algorithms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant