Remove deprecated RPC code #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: twisted.runner.inetdconf.InvalidRPCServicesConfError twisted.runner.inetdconf.RPCServicesConf twisted.runner.inetdtap.RPCServer twisted.runner.portmap
Codecov Report
@@ Coverage Diff @@
## trunk #700 +/- ##
==========================================
+ Coverage 89.62% 91.19% +1.57%
==========================================
Files 844 843 -1
Lines 147851 147797 -54
Branches 13065 13062 -3
==========================================
+ Hits 132518 134790 +2272
+ Misses 12919 10751 -2168
+ Partials 2414 2256 -158 |
glyph
approved these changes
Feb 2, 2017
|
Should I wait until 5/18/2017 to remove this, as per the comments for a similar review here: |
|
Oh, crud, that's a good point. I had already forgotten that 16.x wasn't month-based and so 16.2 and 17.2 aren't a year apart. So yes, this approval stands, but we should probably wait a few months to click the merge button. |
|
I'll set my alarm clock for 5/19/2017! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/8464