Remove deprecated twisted.protocols.oscar #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This was deprecated in 16.2 which was released 2016-05-18. Or deprecation policy indicates that we shouldn't remove this until after 2017-05-18. I'm going to close this for the moment, but feel free to reopen this after that. |
|
There is no need to close this. @glyph approved a similar review which cannot be merged until 5/19/2017, |
Codecov Report
@@ Coverage Diff @@
## trunk #701 +/- ##
==========================================
+ Coverage 89.63% 89.93% +0.29%
==========================================
Files 843 841 -2
Lines 147797 146978 -819
Branches 13062 12563 -499
==========================================
- Hits 132478 132183 -295
+ Misses 12938 12412 -526
- Partials 2381 2383 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/9024