[9539] Tidy up Deferred.fromFuture() intersphinx references #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asyncio docs have been reorganized, invalidating this reference.
This is an alias for asyncio.ensure_future which has been deprecated since 3.4.4. It isn't even syntactically usable as of Python 3.6. It seems best to remove this reference to it. https://docs.python.org/3.4/library/asyncio-task.html#asyncio.async
Codecov Report
@@ Coverage Diff @@
## trunk #1070 +/- ##
==========================================
+ Coverage 91.76% 91.92% +0.15%
==========================================
Files 844 844
Lines 150865 150865
Branches 13157 13157
==========================================
+ Hits 138442 138680 +238
+ Misses 10284 10099 -185
+ Partials 2139 2086 -53 |
altendky
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Intermittent build failure noted: https://twistedmatrix.com/trac/ticket/8879#comment:15
Gets my approval.
|
Thank you for the review, @altendky! I will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
asyncio.AbstractEventLoop.create_task()→asyncio.loop.create_task(), as it has moved upstream. Resolves this warning:Remove reference to
asyncio.asyncas it was deprecated in Python 3.4.4 and produced this warning:In combination with #1069 this should get us a clean documentation build.
Contributor Checklist: