[9625] improve cloud code coverage configuration #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
glyph
commented
Apr 13, 2019
•
glyph
commented
- separate coverage preparation and publishing
- add coverage publishing to circle macOS builders
- add publishing to coveralls, which might actually be the good one now
- keep publishing to codecov so we can compare
- separate coverage preparation and publishing - add coverage publishing to circle macOS builders - add publishing to coveralls, which might actually be the good one now
Codecov Report
@@ Coverage Diff @@
## trunk #1129 +/- ##
==========================================
- Coverage 91.99% 89.47% -2.52%
==========================================
Files 844 844
Lines 151053 151053
Branches 13158 13158
==========================================
- Hits 138955 135155 -3800
- Misses 10000 13415 +3415
- Partials 2098 2483 +385 |
glyph
changed the title
|
I'm going to merge this unilaterally because it is coupled to stateful configuration changes made in various web services, and I believe other PRs are going to start getting bogus build statuses that report incorrect things about coverage if I don't land it or roll those back. Also, it's not a code change, it's a config change to how CI works. I am happy to take feedback or roll this back if anyone disagrees with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.